Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shadow-clj support #8

Open
ZabelTech opened this issue Aug 14, 2021 · 4 comments
Open

shadow-clj support #8

ZabelTech opened this issue Aug 14, 2021 · 4 comments

Comments

@ZabelTech
Copy link

Hi @viebel ,
I'm coming over from viebel/klipse#353 (plugging in shadow-cljs support)
Shadow-cljs intentionally hardcodes the compiler flag dump-core to false, that means the analyzer-cache will be empty initially and we need to put in cljs.core by hand.
For this I need you to put the analyzer cache for cljs.core up next to core$macros.cljc.cache.json in the bundled-ns-root.
I can make the rest happen then, sounds good?

@viebel
Copy link
Owner

viebel commented Aug 14, 2021

I don't understand what you mean by "to put the analyzer cache for cljs.core up next to core$macros.cljc.cache.json in the bundled-ns-root."
Could you open a PR for it?

@ZabelTech
Copy link
Author

@viebel Sure, there will be a PR.

But what I was trying to say above is:
To get it going with shadowcljs the analyzer cache for cljs.core needs to be hosted. Just like you allready do it with the marcos.

Here is a somewhat lengthy discussion about the technical details: thheller/shadow-cljs#922

Tldr: Thats currently the only possible solution and it's pretty likely the best one from a ux perspective.

So, the deal would be:
You put the analyzer cache of cljs.core where you host the other 'bundled' namespace caches.
I'm going to handle the Code.
You will get a PR and than we close the long standing issue about the shadowcljs support.
Sounds good?

@viebel
Copy link
Owner

viebel commented Aug 20, 2021

Sounds perfect @ZabelTech !
In fact, the analyzer cache for cljs.core is already hosted.
The hosting of analyzer cache is handled in this repo https://github.com/viebel/cljs-analysis-cache.
The hosted files come from this folder https://github.com/viebel/cljs-analysis-cache/tree/master/cache

Let me know if you need further explanation.

@ZabelTech
Copy link
Author

thanks @viebel, I have everything that I need for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants