Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate prettier for --fix #37

Open
brandonocasey opened this issue Sep 6, 2018 · 1 comment
Open

Integrate prettier for --fix #37

brandonocasey opened this issue Sep 6, 2018 · 1 comment
Labels
major

Comments

@brandonocasey
Copy link
Contributor

This should allow us to have much more control over the resulting code from --fix

See: https://github.com/prettier/prettier
@gkatsev
Copy link
Member

gkatsev commented Sep 6, 2018

I don't think we should do this. We should either use prettier and integrate it as a precommit hook or something or just continue using eslint.
I'm leaning towards just staying with eslint for now, especially since --fix works with quite a lot of stuff now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gkatsev @brandonocasey