Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

critical code enhancements #51

Open
dasois opened this issue Aug 27, 2014 · 1 comment
Open

critical code enhancements #51

dasois opened this issue Aug 27, 2014 · 1 comment
Labels
enhancement
Milestone
1.2.0

Comments

@dasois
Copy link
Contributor

dasois commented Aug 27, 2014

The code has several critical design fallacies, wich have to be corrected, primarily being:

  • operating on global namespace
  • polluting $rootScope
  • several misusages of the 'this'-function
  • some Angular module weirdness...
@dasois dasois added this to the 1.1.0 milestone Aug 27, 2014
@dasois dasois self-assigned this Aug 27, 2014
@victorb
Copy link
Owner

victorb commented Sep 26, 2014

Hey! Thanks for the added issue @dasois.

Some more information regarding "several misusages of the 'this'-function" and "some Angular module weirdness..." would be helpful and I'll try looking into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@victorb @dasois