Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling must not belong to JavaScript #33

Open
slavafomin opened this issue Apr 9, 2014 · 4 comments
Open

Styling must not belong to JavaScript #33

slavafomin opened this issue Apr 9, 2014 · 4 comments

Comments

@slavafomin
Copy link

Presentation must be separate from business logic.

I suggest to deprecate methods like height and color and replace them with CSS styling completely.

Right now I can't use my SCSS styles and variables to style progress bar and this is really wrong.

@daviesgeek
Copy link
Contributor

@slavafomin Agreed.

@dasois
Copy link
Contributor

dasois commented May 24, 2014

+1

@JDWardle
Copy link
Contributor

I'll be submitting a pull request for this later. It seems to be as simple as removing the hard coded css values in the provider in order for overriding the css to actually work. The height and color functions will still be there but won't be necessary to use.

dasois added a commit that referenced this issue Jul 24, 2014
Removed hard coded styling. #33
@dasois dasois closed this as completed Jul 24, 2014
dasois added a commit that referenced this issue Jul 24, 2014
dasois added a commit that referenced this issue Jul 24, 2014
Revert "Removed hard coded styling. #33"
@dasois dasois reopened this Aug 27, 2014
@victorb
Copy link
Owner

victorb commented Sep 26, 2014

Yeah, a solution where styles isn't hardcoded but still possible to change color via JavaScript would be acceptable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants