Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing basic auth to be passed in environment variable to hide it from the rest of users #240

Closed
puzzle-star opened this issue May 5, 2024 · 4 comments

Comments

@puzzle-star
Copy link

Currently, client basic auth can be passed with --basic-auth parameter. This allows, anyway, the passed credentials to be seen by any user.

Could you please consider allowing the same value to be passed as environment variable to hide it from the rest of the users? (i.e. WEBSOCAT_BASIC_AUTH)

@vi
Copy link
Owner

vi commented May 6, 2024

Are environment variables better protected than command line arguments? Or the latter just catch one's attection in top output while the former require to dig though /proc/N/environ?

Typically secrets are moved from program arguments to files to avoid exposure, not to envvars as far as I know.

@puzzle-star
Copy link
Author

puzzle-star commented May 6, 2024 via email

@puzzle-star
Copy link
Author

puzzle-star commented May 6, 2024 via email

@vi vi closed this as completed in e289e9f May 9, 2024
@puzzle-star
Copy link
Author

Working as expected, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants