-
|
One more question, is in some way possible to add the "ContactsContract.Data.IS_READ_ONLY" flag on add/update with the actual release? |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments 19 replies
-
|
I have not played around with that field. I'll take a look at it this week to see what it's all about =) |
Beta Was this translation helpful? Give feedback.
-
|
Thanks, here a snipped from the source code how I use it: |
Beta Was this translation helpful? Give feedback.
-
|
I do have a question. The title of this discussion is about setting Contacts to be read-only, yet the ContactsContract constant you are referencing is specific to Data table rows. Are you interested in making data table rows read-only or also RawContact table rows too? I remember in a different discussion I was unable to read/write the value of Since you are working on sync adapters, you have higher privileges than regular applications. This library is tailored for application usage, not sync adapters. So, I don't want to add too much sync-adapter-only functionality into the library (at least for now). However, if it can also be used by regular applications in some way, I will be inclined to add support for it into this library =) Anyways, I will have a deeper look into read-only RawContacts and Data rows this week. |
Beta Was this translation helpful? Give feedback.
-
|
I spent a little bit of time digging. Here's what I have so far. Attempting to read the I tried on a Google Pixel 4 API 33 emulator and on my physical Google Pixel 6 Pro API. I don't know what's going on there. I did not find anything either when searching the internet... So, I'll have to skip As for the other read-only flag in ContactsContract, Next, I'll focus on investigating |
Beta Was this translation helpful? Give feedback.
-
|
Hmmm.... I'm also getting an exception when attempting to read @marrale, can you try logging it? Do you also get an exception? You can use the following code to log it, fun Context.logDataTable() {
val cursor = contentResolver.query(
ContactsContract.Data.CONTENT_URI,
arrayOf(
ContactsContract.Data._ID,
ContactsContract.Data.RAW_CONTACT_ID,
ContactsContract.Data.CONTACT_ID,
ContactsContract.Data.IS_READ_ONLY
),
null,
null,
null
)
cursor ?: return
while (cursor.moveToNext()) {
// Use getString instead of getLong, getInt, etc so that the value could be null.
val id = cursor.getString(0)
val rawContactId = cursor.getString(1)
val contactId = cursor.getString(2)
val readOnly = cursor.getString(3)
log("Data id: $id, rawContactId: $rawContactId, contactId: $contactId, readOnly: $readOnly")
}
cursor.close()
}If reading the read-only value is not possible, I'm less inclined to add it to the APIs... Next, I will take a look at the effects of inserting data rows with |
Beta Was this translation helpful? Give feedback.
-
|
Okay, so... Here's what I found... We can set the the value of Take this for example... Using the sample app in this repo with some local code changes, I created a RawContact named "Bob". It has two data rows. One is read-only and the other is not.
Here is what happens when attempting to change the name and email values using Contacts apps... aosp-contacts.movsample-contacts.movgoogle-contacts.movAll of the above contacts app shows that the update succeeded. The email did get updated BUT the name did not because it is read-only. Note that even if only the name is changed, the apps still show updated succeeded. This means that we cannot really check if the update truly applied the changes (unless we perform a query and compare before-and-after). This is just a limitation we will have to live with. If sample-contacts-caller-is-sync-adapter.movOf course, it will be up to the Account's sync adapter to update the backend in order to persist changes across devices. As for |
Beta Was this translation helpful? Give feedback.
-
|
With all that said, I created several issues that should support your use case. I don't necessarily agree that these things should be added to this library. However, I can see value in it since it can help devs that are trying to do the same or similar things as you.
I just have to make sure these new additions are properly documented so that average users of this library do not use them unnecessarily or incorrectly. I will include all of the above issues in the next release, 0.3.1. I'm busy with work and life so I may not be able to make the release until later next week 😄 |
Beta Was this translation helpful? Give feedback.
-
|
@vestrel00 thanks for taking your time for this exhaustive testing and explanation. And thanks to add the "ContactsContract.DataColumns.IS_READ_ONLY" to your library, this will really help me for my purpose and I'm able to fully use your library. About the "ContactsContract.RawContactsColumns.RAW_CONTACT_IS_READ_ONLY" I guess is totally related to Sync adapter. I never try it, if I will give it a try in the future. As I said before, the "ContactsContract.DataColumns.IS_READ_ONLY" fulfil my purpose. About the release, don't hurry, I will be very happy if you will be able to release it end of next week, but also if it is later on, no problem. Thanks a lot. |
Beta Was this translation helpful? Give feedback.
-
|
@marrale, I completed all of the issues and am ready to release the next version (0.3.1) next week! In addition to the Insert new RawContacts with data set to read-only, contactsApi
.insert()
.rawContact {
addEmail {
isReadOnly = true
address = "[email protected]"
type = EmailEntity.Type.WORK
}
setName {
isReadOnly = true
givenName = "Abc"
}
setNickname {
isReadOnly = true
name = "Alphabet"
}
setNote {
isReadOnly = true
note = "The english alphabet"
}
...
}
.commit()I also added an extension function so that you can set the read-only property of all data of the RawContact in one call, contactsApi
.insert()
.rawContact {
addEmail {
address = "[email protected]"
type = EmailEntity.Type.WORK
}
setName {
givenName = "Abc"
}
setNickname {
name = "Alphabet"
}
setNote {
note = "The english alphabet"
}
...
// Make sure to call this after you've set/added all RawContact data.
setDataAsReadOnly(true)
}
.commit()As discussed, I am unable to include the val readOnly: Boolean? = rawContact.name?.isReadOnly(contactsApi)
val readOnlyMap: Map<Long, Boolean> = rawContact.dataList().isReadOnlyMap(contactsApi)Additionally, you are now able to create instances of the val contactsApi = Contacts(context, callerIsSyncAdapter = true)@marrale, please let me know if these changes suffice. If you need anything else, please let me know so that I can include it in the next release (if it is not too much effort) 🙏 |
Beta Was this translation helpful? Give feedback.
-
|
@vestrel00 thanks a lot for your effort, really appreciated. It looks like your improvments includes everything (and more) needed for my purpose. Especially I love this extension function "setDataAsReadOnly(true)". I'm looking forward to the library release of next week. BR Alessandro |
Beta Was this translation helpful? Give feedback.
-
|
🔥 🔥 🔥 🔥 🔥 🔥 🔥 🔥 |
Beta Was this translation helpful? Give feedback.
With all that said, I created several issues that should support your use case. I don't necessarily agree that these things should be added to this library. However, I can see value in it since it can help devs that are trying to do the same or similar things as you.
I just have to make sure these new additions are properly documented so that average users of this library do not use them unnecessarily or incorrectly.
I will include all of the above issues in the next release, 0.3.1. I'm busy with work and life so I may not be able to make the release until later next week 😄