Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbosity of verticapy #952

Open
wthomare opened this issue Nov 30, 2023 · 6 comments
Open

Verbosity of verticapy #952

wthomare opened this issue Nov 30, 2023 · 6 comments
Assignees
Labels
Config | Utils Config and utils functions. Enhancement Improving an existing function.

Comments

@wthomare
Copy link

wthomare commented Nov 30, 2023

Hello,

Due to production restriction, It will be great if the verbosity of vertica/verticapy will be tunable by a parameter and if the actual logs could be ingest by a standard python logger.

The parameter could be set in the connection and have those values :

  • 0 (silent)
  • 1 (warning)
  • 2 (info)
  • 3 (debug)

Does this parameter already exist and we missed it ?
Does such a feature is on a roadmap or can we help you ?

Wilfried Thomaré - MLOps

@oualib oualib added Enhancement Improving an existing function. Config | Utils Config and utils functions. labels Dec 1, 2023
@oualib oualib added this to the VerticaPy 1.0.1 milestone Dec 1, 2023
@afard
Copy link
Collaborator

afard commented Dec 1, 2023

Hello Wilfried,

Thanks for your valuable feedback.

If I understand it correctly, you are suggesting to add a capability to silence the displayed messages of all VerticaPy functions based on their importance, right?

There are currently a few configuration knobs like a print_info parameter to control printing of some information, but there is no comprehensive global knob to adjust the verbosity of all functions based on their level of importance. We like your suggestion and are planning to implement it in VerticaPy. Meanwhile, it would be great to learn more about the "production restriction" in your environment. It would be helpful if you can provide a few examples. This will help us to make sure your concerns will be addressed properly.

Best regards,
Arash

@oualib
Copy link
Member

oualib commented Dec 6, 2023

@wthomare can you please take time to give us more precision so we can implement a feature which can fit your needs?

@wthomare
Copy link
Author

wthomare commented Dec 6, 2023

Hello,

Sorry for the delay. First of all, thanks for the tips with print_info. It's solved all our issues of message flooding in production.

But It doesn't change that It would be better if we can catch those logs into a real python logger instead of printed.
It will great for differents reasons :

  • The performance monitoring with logstash (check the stability, variations, ... of some operations).
  • Application monitoring when you have an error in production. Because prints are lost when a production instance is closed after a crash and not the logs.
  • Formating the logs in accordance with the standart of our different companies
  • With prints, you have no timestamps with the message and no synchronisation with the loggers already present in our treatment
  • And all the over cons/pro of logger VS print ...

BS,
Wilfried

@afard
Copy link
Collaborator

afard commented Dec 6, 2023

Hello Wilfried,

I'm glad that your message related issues are resolved.
Thanks for your valuable suggestions. We are planning to modernize the logging mechanism of VerticaPy.

Best regards,
Arash

@oualib oualib self-assigned this Dec 28, 2023
@oualib
Copy link
Member

oualib commented Feb 27, 2024

@afard do you think you can work on this?

@afard
Copy link
Collaborator

afard commented Feb 27, 2024

@afard do you think you can work on this?

@oualib, I should be able to work on this in the 2nd or the 3rd week of March.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config | Utils Config and utils functions. Enhancement Improving an existing function.
Projects
None yet
Development

No branches or pull requests

3 participants