Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repeating-linear-gradient() is not working when rendered as png, svg or pdf #554

Open
LouisCuvelier opened this issue Sep 22, 2023 · 3 comments · May be fixed by #564
Open

repeating-linear-gradient() is not working when rendered as png, svg or pdf #554

LouisCuvelier opened this issue Sep 22, 2023 · 3 comments · May be fixed by #564

Comments

@LouisCuvelier
Copy link

Bug report

Description / Observed Behavior

repeating-linear-gradient() as background-image is not working when rendered as png, svg or pdf.

Expected Behavior

Show the repeating-linear-gradient() even with png output.

Reproduction

Issue reproduced here
@LouisCuvelier LouisCuvelier mentioned this issue Sep 22, 2023
Merged
@Jackie1210
Copy link
Contributor

I would take a look tomorrow! It's midnight in china🥲 @LouisCuvelier

@Jackie1210
Copy link
Contributor

Currently repeating-linear-gradient is not supported. I'll implement it recently!

@Jackie1210
Copy link
Contributor

just NOTE: I have been finding the correct algorithm for almost a week, which is not explicitly described on spec, on calculating the x1, x2, y1, y2 of linearGradient when gradientUnits is objectBoundingBox. But I finally solved it accidentally (😆). Anyway, next stage is code.

@Jackie1210 Jackie1210 linked a pull request Oct 18, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support repeating-linear-gradient Jackie1210/satori
2 participants
@Jackie1210 @LouisCuvelier