Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for UrlObject #8

Open
korsvanloon opened this issue May 1, 2024 · 3 comments · May be fixed by #9
Open

Add support for UrlObject #8

korsvanloon opened this issue May 1, 2024 · 3 comments · May be fixed by #9

Comments

@korsvanloon
Copy link

The next/link object can have a regular object as href, but the react-transition-progress link calls toString on the href resulting in [Object object].
It needs the format function from the url library instead:

import { format } from "url";

const hrefString = typeof href === "string" ? href : format(href)
@timneutkens
Copy link
Member

Feel free to send a PR.

@korsvanloon korsvanloon linked a pull request May 15, 2024 that will close this issue
@korsvanloon
Copy link
Author

here you go :)
added in an extra fix for scroll behaviour

@korsvanloon
Copy link
Author

@timneutkens Could you please have a look at my PR? And trigger another release?
The CMD+click fix would also be great to have released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants