Bug: Adding a custom domain with an initial misconfigured DNS config keeps staying in error mode forever

[Xennis]

Issue

Under certain conditions, a custom domain never gets green in the UI. It's stuck in "Invalid Configuration".

The "verify" endpoint keeps returning an "Invalid Configuration". If you call the Vercel API manually via cURL it shows "misconfigured": false.

Steps to reproduce

• Add a custom domain
• Misconfigure the DNS settings for this domain
• See in the UI the "Invalid Configuration" error (or call the "verify" endpoint)
• Fix the DNS settings so they are correct
• In the UI you continue to see an "Invalid Configuration" (or call the "verify" endpoint)

Analysis

• The verify endpoint calls the getConfigResponse. This function uses fetch

platforms/lib/domains.ts

Lines 85 to 96 in 29e20e7

	return await fetch(
	`https://api.vercel.com/v6/domains/${domain}/config${
	process.env.TEAM_ID_VERCEL ? `?teamId=${process.env.TEAM_ID_VERCEL}` : ""
	}`,
	{
	method: "GET",
	headers: {
	Authorization: `Bearer ${process.env.AUTH_BEARER_TOKEN}`,
	"Content-Type": "application/json",
	},
	},
	).then((res) => res.json());

• According to the documentation fetch is cached by default. In the file, neither a locale nor a global revalidate is configured.

=> Theory: The issue appears because the fetch in getConfigResponse is cached and never revalidated. Due to the initial misconfiguration, the function and hence the whole endpoint keeps returning an "Invalid Configuration".

A possible fix is to add a revalidation or turn off caching for this particular fetch.