Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Ctrl+Enter sends ASCII 13 \r instead of ASCII 10 \n #7844

Open
2 tasks done
gamepad-coder opened this issue Mar 17, 2024 · 0 comments
Open
2 tasks done

[bug] Ctrl+Enter sends ASCII 13 \r instead of ASCII 10 \n #7844

gamepad-coder opened this issue Mar 17, 2024 · 0 comments

Comments

@gamepad-coder
Copy link

  • I am on the latest Hyper.app version
  • I have searched the issues of this repo and believe that this is not a duplicate
  • OS version and name:
    • OS Name: Microsoft Windows 11 Pro
    • Version: 10.0.22621 Build 22621
  • WSL 2:
    • Debian: Debian GNU/Linux 11 (bullseye)
    • WSL version: 2.1.5.0
    • Kernel version: 5.15.146.1-2
  • Hyper.app version: 3.4.1 (stable)
  • Link of a Gist with the contents of your hyper.json: reproducible on Is Vanilla
  • Relevant information from devtools: N/A
  • The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue

=== Issue ===
ctrl + enter does not work correctly in Hyper.

=== Expectation ===
When using a Linux bash shell, it's typical for the terminal emulator to return different codes for enter and ctrl + enter:

  • enter: expected to return ASCII code 13 \r
  • ctrl + enter: expected to return ASCII code 10 \n
  • ctrl + j: expected to return ASCII code 10 \n

=== Example ===

Screenshot 2024-03-17 171213

=== Impact ===
Many modern apps and webapps use enter within text editors, but have a dedicated hotkey for ctrl+enter to submit.

Many other terminals can distinguish between enter and ctrl+enter out of the box.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant