Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xterm includes its own hard-coded map #7737

Open
2 tasks done
JJJ opened this issue Jan 21, 2024 · 0 comments
Open
2 tasks done

xterm includes its own hard-coded map #7737

JJJ opened this issue Jan 21, 2024 · 0 comments

Comments

@JJJ
Copy link

JJJ commented Jan 21, 2024

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: macOS 14.3 Sonoma

  • Hyper.app version: latest canary

  • Relevant information from devtools:

DevTools failed to load source map: Could not parse content for file:///hyper/target/xterm.js.map: Unexpected end of JSON input
  • The issue is reproducible in vanilla Hyper.app: Yes

Issue

DevTools attempts to load an xterm.js.map file from the target directory.

This is because xterm.js has this at the end of it:

//# sourceMappingURL=xterm.js.map

...which makes sense from xterm's perspective, but not from Hyper's.

Uncertain when exactly this started (I think it's been a while).


Two solutions:

  • modify xterm.js to strip out the manual map
  • always (or conditionally, I suppose) manually require xterm.js.map
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant