Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select All operation is not possible in the search bar #6733

Open
2 tasks done
naktinis opened this issue Aug 29, 2022 · 1 comment · May be fixed by #7736
Open
2 tasks done

Select All operation is not possible in the search bar #6733

naktinis opened this issue Aug 29, 2022 · 1 comment · May be fixed by #7736

Comments

@naktinis
Copy link

  • I am on the latest Hyper.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: macOS 12

  • Hyper.app version: 3.3.0 (but also built canary from source)

  • Link of a Gist with the contents of your .hyper.js: N/A

  • Relevant information from devtools (CMD+ALT+I on macOS, CTRL+SHIFT+I elsewhere): N/A

  • The issue is reproducible in vanilla Hyper.app: Is Vanilla

Issue

Impossible to use the "Select All" command in the search bar. Either pressing "Cmd + A" on the keyboard, or right clicking the search bar and selecting "Select All" in the menu, performs "Select All" on the terminal window rather than the search bar.

Selecting all text in the search bar is really useful when navigating through the terminal content, and also this selecting the terminal content while the search box is in focus is really unexpected from the usability perspective.
@naktinis naktinis changed the title Pressing Select All operation is not possible in the search bar Aug 29, 2022
@KoStard
Copy link

KoStard commented Dec 24, 2023

I found this frustrating as well. It's frustrating experience on the search bar (also command + arrow/delete navigations don't work)

JJJ added a commit to JJJ/typhoon that referenced this issue Jan 21, 2024
@JJJ
Only handle "Select All" when Term has focus (identified by document.…
aa17f39 
…activeElement).

Fixes vercel#6733.
@JJJ JJJ linked a pull request Jan 21, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only handle "Select All" when Term has focus JJJ/typhoon
2 participants
@naktinis @KoStard