Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License issue? #7

Open
riccardobl opened this issue Sep 8, 2018 · 4 comments
Open

License issue? #7

riccardobl opened this issue Sep 8, 2018 · 4 comments

Comments

@riccardobl
Copy link

Hello, first of all, nice work. :squirrel:
I'm working on an opensource code that will be released under a permissive license and i have add some reverberation to an audio source, your reverb implementation is exactly what im looking for, but i've read the readme and it says

The reverb effect is a complete rewrite of Freeverb3's Progenitor2 algorithm.

afaik Freeverb3 is a gnu library under gnu gpl license, due to the properties of this license, shouldn't this code be licensed under gpl aswell?

@KaneRoot
Copy link

KaneRoot commented Sep 8, 2018

Maybe is there a way to isolate the GPL license to this file only. I just discovered this project yesterday and it's awesome, hope to integrate it in my projects some day, don't want it to be GPL'd.

@velipso
Copy link
Owner

velipso commented Sep 8, 2018

I don't believe it falls under GPL, because it is a rewrite from scratch. I.e., no copy/pasted code, and if you actually look at Freeverb vs sndfilter code, you can tell it is completely different. The algorithm is the same (or, should be), but the implementation is completely different.

This is no different than Linux being a rewrite of Unix, imo.

Of course, I'm not a lawyer. But I can tell you that I spent a lot of effort reading the Freeverb codebase, figuring out the algorithm behind it, and reimplementing it. Like I said, just compare the source files, it's very obvious.

@riccardobl
Copy link
Author

Thanks for the reply.
It seems to me that this may fall into a grey area 🤔 , since gpl covers derivate work, and this may be seen as a derivate work, or at least that's how the last part in the readme may be interpreted, but I'm not a lawyer either.

@weepy
Copy link

weepy commented Jan 16, 2019

generally it's not possible to license an algorithm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants