[Feature Request] - Make SAMBA share optional

[ogarcia]

Description

Right now you need to enter the SAMBA share to be able to connect to the remote, it would be interesting to make this optional and to list the shares in case you are not provided with any.

Changes

Make the share field of the form optional and in that case list the remote shares.

[0323pin]

Actually, I would prefer if the whole smb module could be feature gated, veeso/pavao#5 (comment)

[veeso]

It doesn't look like libsmbclient has a function to list shares, or I cannot find it 🤷🏻

[ogarcia]

It doesn't look like libsmbclient has a function to list shares, or I cannot find it 🤷🏻

I don't understand much about C, but this is the function that lists the shares in smbclient: https://github.com/samba-team/samba/blob/master/source4/client/client.c#L2684

Maybe with that information something can be done.

[veeso]

Oook, it looks like it's only in SMB4. It could be a future development, but I'd need to think about how to display on the UI, it may be not that easy to handle tbh