Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change &mut self to &self in RemoteFs #19

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Change &mut self to &self in RemoteFs #19

merged 2 commits into from
Jan 11, 2022

Conversation

ok-nick
Copy link
Contributor

@ok-nick ok-nick commented Jan 9, 2022

Fixes #18
This was blocking for me so I went ahead and implemented it. Still needs to be implemented in the other crates.

@coveralls
Copy link

coveralls commented Jan 9, 2022

Pull Request Test Coverage Report for Build 1673227912

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.703%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/fs/mod.rs 0 6 0.0%
Totals Coverage Status
Change from base Build 1653098513: 0.0%
Covered Lines: 440
Relevant Lines: 589

💛 - Coveralls

@ok-nick ok-nick closed this Jan 9, 2022
@ok-nick ok-nick reopened this Jan 9, 2022
@veeso veeso changed the base branch from main to 0.3.0 January 11, 2022 15:17
@veeso veeso merged commit ef21b90 into veeso:0.3.0 Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RemoteFs methods should take immutable self
3 participants