Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nonstandard klog / glog severity levels #843

Open
srstrickland opened this issue May 17, 2024 · 1 comment
Open

Nonstandard klog / glog severity levels #843

srstrickland opened this issue May 17, 2024 · 1 comment
Labels
type: enhancement A value-adding code change that enhances its existing functionality vrl: stdlib Changes to the standard library

Comments

@srstrickland
Copy link

We have some applications which use klog or glog format with "nonstandard" log levels (generally common, but technically not part of either spec), namely "D" for debug and "T" for trace. In my parsing code, I can apply VRL workarounds, but I'm wondering what the appetite would be for the 2-line change (here and here) to support parsing these? I'm happy to submit a PR, but I realize it's a bit esoteric and perhaps I should just keep my VRL hack.

D0505 17:59:40.692994   28133 klog.go:70] hello from klog  # level = debug
T0505 17:59:40.692994   28133 klog.go:70] hello from klog  # level = trace
@jszwedko
Copy link
Member

Thanks for raising this @srstrickland. I think we'd support that, I can see why they would be common. I would just note it in the code with comments that they are non-standard.

@jszwedko jszwedko added type: enhancement A value-adding code change that enhances its existing functionality vrl: stdlib Changes to the standard library labels May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement A value-adding code change that enhances its existing functionality vrl: stdlib Changes to the standard library
Projects
None yet
Development

No branches or pull requests

2 participants