Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace heim with sysinfo [ fix build on FreeBSD ] #20414

Open
yonas opened this issue May 1, 2024 · 1 comment
Open

Replace heim with sysinfo [ fix build on FreeBSD ] #20414

yonas opened this issue May 1, 2024 · 1 comment
Labels
domain: platforms Anything related to Vector's supported platforms source: host_metrics Anything `host_metrics` source related type: bug A code related bug.

Comments

@yonas
Copy link

yonas commented May 1, 2024

A note for the community

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

Replacing heim with sysinfo will fix building on FreeBSD.

Configuration

No response

Version

0.37.1

Debug Output

No response

Example Data

No response

Additional Context

No response

References

No response

@yonas yonas added the type: bug A code related bug. label May 1, 2024
@jszwedko jszwedko added source: host_metrics Anything `host_metrics` source related domain: platforms Anything related to Vector's supported platforms labels May 3, 2024
@jszwedko
Copy link
Member

jszwedko commented May 3, 2024

As mentioned in #10614 we could also support FreeBSD by disabling the host_metrics source for it. There is already some precedent for platform specific sources (mostly between Linux and Windows). This is likely to be less work than swapping out heim for sysinfo. I think we'd also like to see an RFC comparing the alternatives, and whether sysinfo can satisfy the currently published metrics by the host_metrics source before moving forward with sysinfo.

sysinfo was compared at the time heim was chosen (see https://github.com/vectordotdev/vector/blob/master/rfcs/2020-08-26-3191-host-metrics.md). Granted that was when heim was still maintained and sysinfo lacked FreeBSD support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: platforms Anything related to Vector's supported platforms source: host_metrics Anything `host_metrics` source related type: bug A code related bug.
Projects
None yet
Development

No branches or pull requests

2 participants