prometheus_pushgateway failed decompressing payload

[sosop]

A note for the community

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Problem

reporting node exporter metrics with gzip, prometheus_pushgateway can not get the metrics, failed decompressing payload, encoding=gzip

Configuration

No response

Version

0.37.0

Debug Output

No response

Example Data

No response

Additional Context

No response

References

No response

[jszwedko]

Thanks for filing this @sosop ! Are you able to capture one of the requests that the client is sending? I took a quick look at the code and it is already handling gzip decompression if the Content-Encoding is set to gzip. This happens here:

vector/src/sources/util/http/encoding.rs

Lines 11 to 48 in e4e0ea5

	pub fn decode(header: Option<&str>, mut body: Bytes) -> Result<Bytes, ErrorMessage> {
	if let Some(encodings) = header {
	for encoding in encodings.rsplit(',').map(str::trim) {
	body = match encoding {
	"identity" => body,
	"gzip" => {
	let mut decoded = Vec::new();
	MultiGzDecoder::new(body.reader())
	.read_to_end(&mut decoded)
	.map_err(|error| handle_decode_error(encoding, error))?;
	decoded.into()
	}
	"deflate" => {
	let mut decoded = Vec::new();
	ZlibDecoder::new(body.reader())
	.read_to_end(&mut decoded)
	.map_err(|error| handle_decode_error(encoding, error))?;
	decoded.into()
	}
	"snappy" => SnappyDecoder::new()
	.decompress_vec(&body)
	.map_err(|error| handle_decode_error(encoding, error))?
	.into(),
	"zstd" => zstd::decode_all(body.reader())
	.map_err(|error| handle_decode_error(encoding, error))?
	.into(),
	encoding => {
	return Err(ErrorMessage::new(
	StatusCode::UNSUPPORTED_MEDIA_TYPE,
	format!("Unsupported encoding {}", encoding),
	))
	}
	}
	}
	}
	Ok(body)
	}

[sosop]

thanks, it's already handling gzip decompression!!

[jszwedko]

Thanks @sosop . Do you mean it is working for you now?