Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pretty json encoding for better testing / configuring experience #20380

Open
lsampras opened this issue Apr 26, 2024 · 2 comments 路 May be fixed by #20384
Open

Add a pretty json encoding for better testing / configuring experience #20380

lsampras opened this issue Apr 26, 2024 · 2 comments 路 May be fixed by #20384
Labels
domain: codecs Anything related to Vector's codecs (encoding/decoding) type: feature A value-adding code addition that introduce new functionality.

Comments

@lsampras
Copy link

A note for the community

  • Please vote on this issue by adding a 馃憤 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Use Cases

A better UX when users are trying to build/configure their pipeline, the primary usage would be with the console sink.

Pretty-json is much more friendlier to infer the structure of your data.

Attempted Solutions

I've attempted this on my fork and seems to work pretty well, although I might be missing edge cases or making invalid assumptions...

Proposal

Adding a simple encoding would work here based on underlying serde_json::to_writer_pretty implementation.

References

No response

Version

0.37.1

@lsampras lsampras added the type: feature A value-adding code addition that introduce new functionality. label Apr 26, 2024
@lsampras lsampras changed the title Add a pretty json encoding for better viewing experience when testing my configuration Add a pretty json encoding for better testing / configuring experience Apr 26, 2024
@jszwedko
Copy link
Member

Thanks @lsampras ! I took a quick look at your branch and I think this is something we'd accept as a contribution if you feel inclined to open a pull request.

@jszwedko jszwedko added the domain: codecs Anything related to Vector's codecs (encoding/decoding) label Apr 26, 2024
@lsampras lsampras linked a pull request Apr 26, 2024 that will close this issue
@lsampras
Copy link
Author

@jszwedko I've opened #20384 for adding this, Can you take a look at that once?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: codecs Anything related to Vector's codecs (encoding/decoding) type: feature A value-adding code addition that introduce new functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants