Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is sos-notebook compatible with jupyterlab-lsp? #296

Open
rezaeir opened this issue Jun 14, 2020 · 6 comments
Open

Is sos-notebook compatible with jupyterlab-lsp? #296

rezaeir opened this issue Jun 14, 2020 · 6 comments

Comments

@rezaeir
Copy link

rezaeir commented Jun 14, 2020

I just read a Medium article about jupyterlab-lsp extension for Jupyterlab which greatly improves some basic IDE features in jupyterlab environment. I instantly was very curious and eager to check at it out and start using it. However, at the end of the article it mentions that there are some compatibility problems between this extension and the other active jupyterlab extensions. Because I actively use the sos-notebook in my environment, I wanted to first know if you have checked this extension already and if it gets along well with sos-notebook or not?

@BoPeng
Copy link
Contributor

BoPeng commented Jun 14, 2020

I have not personally tried this module but this is an extension that the core team has been eyeing at, perhaps also contributed to to add more language-related features such as linting. The core feature of sos, namely allowing multiple notebooks in one notebook and data exchange between kernels, are not in the scope of lsp (at least not right now).

On the SoS side I have been thinking of adding a few features such as linting but stopped because they are complex issues that are well beyond the scope of SoS. In the end features like %preview was added to preview variables etc but they were "patches" within the classic jupyter framework, but would appear less useful with more comprehensive solutions that LSP will provide, under the more powerful JupyterLab framework.

There is indeed a chance that jupyterlab-lsp and jupyter-sos can conflict in some way but I have full intention to make them work together even if I have to remove some features and point users to jupyterlab-lsp. Please feel free to report here if you notice some related problems.

@rezaeir
Copy link
Author

rezaeir commented Jun 14, 2020

Thanks for your explanation. Alright, then I make a separate, from my rna-seq workflow, env in Ubuntu 20.04 WSL 2 and install both sos and lsp on it and will report any problem which seems to happen because of the combination of sos and lsp.

@BoPeng
Copy link
Contributor

BoPeng commented Jun 14, 2020

I have overheard discussions on this extension from the core developers and did not realize that it is already at a level that is usable. I will install and test it as well.

@BoPeng
Copy link
Contributor

BoPeng commented Jun 14, 2020

Well, just tried.

The sad news is that lsp does not work for the SoS kernel, because it does not know what language SoS is. I will have to ask the LSP guys if it is even possible to notify LSP the language of each cell.

@BoPeng
Copy link
Contributor

BoPeng commented Jun 14, 2020

@rezaeir
Copy link
Author

rezaeir commented Jun 14, 2020

I also just checked that and it doesn't recognize SoS kernel unfortunately. However, it is so slow that even in the single python-kernel notebook it works super slow in popping up hints and references. For r-kernel, it even doesn't fully initialize and indicates "partially initialized!!". I think it is still not usable!! But I'm gonna follow their updates and see how it goes.

@vatlab vatlab deleted a comment from rezaeir Jun 14, 2020
@vatlab vatlab deleted a comment from rezaeir Jun 14, 2020
@vatlab vatlab deleted a comment from rezaeir Jun 14, 2020
@vatlab vatlab deleted a comment from rezaeir Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants