Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of methods / properties in Python more consistent #532

Open
james-whiteside opened this issue Dec 4, 2023 · 0 comments
Open

Make use of methods / properties in Python more consistent #532

james-whiteside opened this issue Dec 4, 2023 · 0 comments

Comments

@james-whiteside
Copy link
Member

james-whiteside commented Dec 4, 2023

Problem to Solve

Recently, the Python driver was updated to replace many methods with properties, for example:

Transaction.query()

became:

Transaction.query

This change was not propagated to all parts of the API, for instance:

Explanation.condition()
ConceptMap.explainables()

should probably be:

Explanation.condition
ConceptMap.explainables

but are currently not. This inconsistency makes the API difficult to work with.

Proposed Solution

Update all existing methods to properties wherever appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants