Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block Potential XSS #1

Open
2 tasks
evanplaice opened this issue Jan 22, 2020 · 0 comments
Open
2 tasks

Block Potential XSS #1

evanplaice opened this issue Jan 22, 2020 · 0 comments

Comments

@evanplaice
Copy link
Member

Due to the eval-like nature of this module, it's possible for externally fetched templates to introduce cross-site-scripting exploits.

To fix this, check the domain of the fetch URL against the site domain. Throw if they don't match. Alternatively, add a param called safe (default true) that -- when set to false -- will allow loading templates from other domains.

Changes

  • add throw if domain-other-than-origin
  • add 'safe' param to circumvent the check when set to false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant