Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block placement rules. #503

Open
rj00a opened this issue Aug 29, 2023 · 0 comments · May be fixed by #511
Open

Add block placement rules. #503

rj00a opened this issue Aug 29, 2023 · 0 comments · May be fixed by #511
Labels
enhancement New feature or request

Comments

@rj00a
Copy link
Member

rj00a commented Aug 29, 2023

Describe the problem related to your feature request.

Valence is lacking placement rules, i.e. the rules that should be followed when a player places or breaks a block. This includes the orientation of logs and stairs, redstone dust, torches, etc.

The client will predict these behaviors so it's important that we have direct support for it.

What solution would you like?

  1. Add a new method to ChunkLayer called place_block, similar to set_block but with placement rules.
  2. Document the difference between set_block and place_block.
  3. Make use of it in the building example.

What alternative(s) have you considered?

Putting this in a separate crate/plugin. But that doesn't seem necessary to me.

Additional context

Here's what Minestom does. Although I think its implementation is incomplete. We should check Vanilla source.

@rj00a rj00a added the enhancement New feature or request label Aug 29, 2023
@rj00a rj00a mentioned this issue Aug 29, 2023
56 tasks
@XBagon XBagon linked a pull request Sep 1, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant