-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow NetworkCallbacks::login access to sending/receiving packets #508
Comments
Are there mods that actually do this? Do you have any use case examples? Just curious |
wiki.vg's article on Packet Channels lists a few mod examples, but I don't know how up to date they are, or how many of them are supposed to be done during Login state. It's also used by Velocity, and that's where |
We already have support for velocity built in, but I suppose it would be better to make it extendable by users. Let's have this be low priority for now. |
Describe the problem related to your feature request.
It would be nice if
NetworkCallbacks::login
implementors could send/receiveLoginQueryRequestS2c
/LoginQueryResponseC2s
packets to allow dealing with clientside mods and whatever elseWhat solution would you like?
The
login
callback could receive a reference toPacketIo
as a parameter. The struct could also have a convenience function for both sending a query and awaiting a response from the client (according to wiki.vg at least it's always supposed to send one back)What alternative(s) have you considered?
Outside of modifying/replacing default Valence crates, none
Additional context
-
The text was updated successfully, but these errors were encountered: