Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up CI for the extractor. #374

Open
rj00a opened this issue Jun 17, 2023 · 0 comments
Open

Set up CI for the extractor. #374

rj00a opened this issue Jun 17, 2023 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers low priority Other issues are more important

Comments

@rj00a
Copy link
Member

rj00a commented Jun 17, 2023 •
edited

Describe the problem related to your feature request.

There is currently no continuous integration for the extractor because it's written in Java and we only have checks for the Rust part of the project. Warnings and style issues can go unnoticed.

What solution would you like?

Set up checks for the Java program like we have for Rust. It should lint for style issues and make sure everything compiles. I don't have any experience with this.

What alternative(s) have you considered?

Leave it as it is because we're lazy or there are too many problems in the code that aren't worth fixing. But I would prefer it if the extractor wasn't totally junk.

Additional context
@rj00a rj00a added enhancement New feature or request good first issue Good for newcomers labels Jun 17, 2023
@dyc3 dyc3 added the low priority Other issues are more important label Jun 17, 2023
@LeoDog896 LeoDog896 mentioned this issue Jun 19, 2023
Merged
rj00a pushed a commit that referenced this issue Jun 19, 2023
@LeoDog896
ci: base extractor-tests (#378)
4f6c868 
## Description

Checks for if the extractor can be compiled in CI, setting the stage for
#374
@rj00a rj00a linked a pull request Feb 11, 2024 that will close this issue
Rewrite Project #599
Closed
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers low priority Other issues are more important
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite Project valence-rs/valence
2 participants
@dyc3 @rj00a