-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows patching of composer.json files? #60
Comments
Hi there! Unfortunately, this is currently not part of the plugin. I've not explored this in-depth, but targeting composer.json will definitely be trickier as it's so central to the whole installation process and unlike the normal process of "let the package install, add patches", this would require a "let the package install, patch it, re-install while keeping patched changes". I'd just take a wild guess and say that it is probably possible, but it's probably going to become a maintenance concern as it'd rely on hovering around Composer internals that normal plugin should not touch. Curious idea though... (gears starting to grind). One thing that the plugin SHOULD be doing right now would be to issue a warning at least that patching certain files has no effect which might not be clear right away :S |
We currently use https://github.com/cweagans/composer-patches but that has a limitation that affects us: you cannot patch the package composer.json. Of course the file is patched but changes are not taken into account when building the dependency tree. I wonder if https://github.com/vaimo/composer-patches knows to resolve that issue.
The text was updated successfully, but these errors were encountered: