Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upscaling acceleration #94

Open
vsemecky opened this issue May 22, 2023 · 2 comments
Open

Upscaling acceleration #94

vsemecky opened this issue May 22, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@vsemecky
Copy link

When I tried InfiniteZoom together with upscaling, I found that it upscales every each frame of the video, which is unnecessary in this case. It would be enough to upscale only the main generated frames and do the zooming on the upscaled ones. That would save a lot of time.

The implementation seemed simple to me, so I wanted to take it on and code this feature directly. However, I found out that there is already the optimize_upscale branch by @GeorgLegato that does exactly this.

I want to ask, what does the future look like with this feature? If that branch isn't in the development, I'd be happy to take it on, I just find the modifications unnecessarily complicated. My idea is more simple:

  1. after generating the images, upscale all of them.
  2. skip/disable upscaling everywhere else
@vsemecky vsemecky added the enhancement New feature or request label May 22, 2023
@vsemecky vsemecky changed the title [FEATURE] Upscaling acceleration May 22, 2023
@GeorgLegato
Copy link
Collaborator

check please the branch overmask_...
beside to smarter upscaling it needs to write upscale/interpolated frames as a stream to video.
older approach is to keep al in ram which is insane for 2 mins/60fps/4k

in the overmask_ branch use the "corner" outpainting strategy, the Center one is not frame corrected but could still work

Corners will extend the target size by your given outpainting width, then zoom in.

@NeoPrint3D
Copy link

Please add upscaling improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants