Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the prompt table #29

Open
egormly opened this issue Apr 17, 2023 · 12 comments
Open

Improving the prompt table #29

egormly opened this issue Apr 17, 2023 · 12 comments
Labels
enhancement New feature or request

Comments

@egormly
Copy link

egormly commented Apr 17, 2023

is super annoying. I am not sure if it's gradio, my system or what but if I try to copy/paste, type or whatever the prompt box gets cleared and I have to click several times. it just seems janky.

Can you just make it a standard text box?

@GeorgLegato
Copy link
Collaborator

your are right,
whatever textbox we use, we have just now added an export and import from file.
go as: create 2 rows, Export Prompts, check the syntax and add your stuff i that json file.
hint: ask chatgpt to create an JSON-Array like [1,"text"], [2,"othertxt"] ...

@deklesen
Copy link
Contributor

I also really don't like that textbox. I frequently delete the content by accident trying to edit it, it doesnt support undo/redo, i don't see a reason why it should be sortable, and rows can't be deleted.

@GeorgLegato
Copy link
Collaborator

@deklesen would you like to update to recent version and test the Export/Import stuff? If you would accept a simple textarea, maybe that export/import is productive enough, before changing too much in this solution yet

@deklesen
Copy link
Contributor

I am on the latest version, the import/export works fine..

I'd prefer a textbox where i enter the json to the current solution, yes...

But then we might have more ui issues down the road, i.e. it has been mentioned somewhere else that the json might contain all generation information (steps, seed once added, etc) and then when entering the json in a textarea its not obvious what should happen, i.e. should the sliders be updated? But then what if the sliders get changed, does the json content override it again when pressing generate?

I'd much prefer if we could have an input somewhat like the current (rows, but with better functionality) and allow import of the json, where upon import, the sliders and prompt table get loaded once, and then thats it.

Sorry for the wall of text 🤪

@v8hid
Copy link
Owner

v8hid commented Apr 17, 2023

@GeorgLegato @deklesen @egormly
Don't worry guys, I'm working on a new custom smooth UI to make a lot of people happy :D

@GeorgLegato
Copy link
Collaborator

@GeorgLegato @deklesen @egormly Don't worry guys, I'm working on a new custom smooth UI to make a lot of people happy :D

please try to reuse the imptr/export approach, was a lot work. we can simplify json without headers etc

@egormly
Copy link
Author

egormly commented Apr 18, 2023

I appreciate the work too, I am not complaining, I will make it work, just wanted to make this an FYI.

@v8hid v8hid added the enhancement New feature or request label Apr 18, 2023
@deklesen
Copy link
Contributor

@GeorgLegato @deklesen @egormly Don't worry guys, I'm working on a new custom smooth UI to make a lot of people happy :D

You're a saint! ❤️ 💪

@jet3004
Copy link

jet3004 commented Apr 19, 2023

is super annoying. I am not sure if it's gradio, my system or what but if I try to copy/paste, type or whatever the prompt box gets cleared and I have to click several times. it just seems janky.

Can you just make it a standard text box?

I just have to say thanks for posting this, it was driving me absolutely crazy and hoped I wasn't the only one, ha.

@v8hid v8hid changed the title Adding prompts Improving the prompt table Apr 19, 2023
@jlitz
Copy link

jlitz commented Apr 23, 2023

i am new but same issue prompt disappears when i attempt to revise it import/export works ok, but prompt box is messed up changes appear at end of prompt can not select spot to make change

@GeorgLegato
Copy link
Collaborator

yes, that the nature of Gradio-Table. first we have to fix other technical stuff, then coming back for ui-improves. grad table is not really the best one

@somenewaccountthen
Copy link

yes, it's driving me crazy. That ENTER key is so easily hit. And edit gone.
What i noticed:

  • text field not wide enough
  • exiting textbox with tab to next control makes it empty .. Lost forever 👎
  • exiting textbox and pressing enter makes it empty .. Lost forever 👎

Will patiently wait till in the meantime as i see it's on the todo list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants