Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken modal in CLM create filter #8757

Closed
Etheryte opened this issue May 16, 2024 · 1 comment
Closed

Broken modal in CLM create filter #8757

Etheryte opened this issue May 16, 2024 · 1 comment
Assignees

Comments

@Etheryte
Copy link
Member

Etheryte commented May 16, 2024

Part of https://github.com/SUSE/spacewalk/issues/18940

All urls below are specified as the dev proxy (yarn proxy https://...), since that's the most convenient way to work on these issues.

To switch between the new theme and the old theme in the console: debugUtils.toggleUpdatedTheme()
To switch between the Suma theme and the Uyuni theme: debugUtils.toggleTheme()


https://localhost:8080/rhn/manager/contentmanagement/filters → Create Filter

The modal is created, but has 0 opacity and other layout issues. This probably extends to other modals, looks like some styles are either missing or incorrectly applied in the new theme.

Old theme:

Screenshot 2024-05-16 at 17 41 33

Definition of done

The updated theme has no visual bugs, all related page urls are added to ViewHelper.java and view-helper.ts.

@Etheryte
Copy link
Member Author

This was fixed in #8775 and #8787.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant