-
Notifications
You must be signed in to change notification settings - Fork 168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make salt keys page consistent with other pages in the updated theme #8734
Comments
Cc @bisht-richa, this probably ties in with the work you're doing on standardizing checkboxes etc. |
@admd is it fine if we drop the green badges in this list? |
@Etheryte I am not so sure about this one. Would we not end up with the a long list of pending/accepted with no badges and that could get bit tricky for the user to see. With clear color distinction for the accepted and pending keys, it was easy for the user to see. We don't have any filtering on the page either so having same color will not help. If we could add some filtering on this page for pending(default)/accepted keys, then we can get rid of these badges. |
Part of https://github.com/SUSE/spacewalk/issues/18940
All urls below are specified as the dev proxy (
yarn proxy https://...
), since that's the most convenient way to work on these issues.To switch between the new theme and the old theme in the console:
debugUtils.toggleUpdatedTheme()
To switch between the Suma theme and the Uyuni theme:
debugUtils.toggleTheme()
Old theme:
New theme:
Imo the new theme is fine as-is, but we need to confirm that this change is fine.
Definition of done
The updated theme has no visual bugs, all related page urls are added to
ViewHelper.java
andview-helper.ts
.The text was updated successfully, but these errors were encountered: