Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using testcontainers and the gerrit docker images for "real" tests of code. #200

Open
PMooreWand opened this issue Aug 20, 2023 · 1 comment

Comments

@PMooreWand
Copy link
Contributor

PMooreWand commented Aug 20, 2023

Not really an issue as closer to a discussion point.
I maintain a similar project as part of testing a modified gerrit code base with my work.
As part of testing that client I've employed the TestContainers package and spin up real gerrit instances on docker as part of the verify step in maven.
I've noticed the RealServerTest class and have used it when working out the PR's I've sent in here, and I was wondering if an integration suite utilising gerrit docker is something this project would be interested in?
Source of current usage I am referring to is here, I use this project's client to prep system for testing the client I'm running.
https://github.com/WANdisco/gerrit-sshd-java-client/blob/main/src/test/java/integration/utils/TestBase.java

@uwolfer
Copy link
Owner

uwolfer commented Aug 24, 2023

Thanks for sharing this idea. I agree, this would make a lot of sense.

Feel free to provide a PR - happy to review it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants