Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code error for n3.py? #3

Open
pangzhan27 opened this issue Jul 14, 2020 · 3 comments
Open

Code error for n3.py? #3

pangzhan27 opened this issue Jul 14, 2020 · 3 comments

Comments

@pangzhan27
Copy link

Based on your paper, Z1 and Z2 should be connected with disjuntion for this NLI task.
However, in n3.py file, it seems that your implement is about conjunction.
i don't know if my understanding is correct.

@t-li
Copy link
Member

t-li commented Aug 5, 2020

Hey, Thank you for the feedback. The repo is not actively monitored. Sorry about the late response.

We are looking at this issue and will update on this soon.

@t-li
Copy link
Member

t-li commented Aug 12, 2020

Hey, triple checking the code and the paper, I think it's a typo in the paper. The code is what we did in the experiments. I just submitted a correction request to the ACL anthropology. Here you go (in case you also want to keep track of that): acl-org/acl-anthology#951

@t-li
Copy link
Member

t-li commented Aug 25, 2020

And we have also updated the arxiv version. FYI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants