We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I tried using fastapi-pagination on a FastAPI + Databases project where I ran databases version 0.9.0 with SQLAlchemy > 2.0.
fastapi-pagination
This line fails: https://github.com/uriyyo/fastapi-pagination/blob/main/fastapi_pagination/ext/databases.py#L30
select([func.count()]) needs to become select(func.count()) (i.e. remove brackets) for SQLAlchemy 2.0.
select([func.count()])
select(func.count())
I'm not sure how you want to handle compatibility with different versions of SQLAlchemy, otherwise I would have created a PR.
The text was updated successfully, but these errors were encountered:
uriyyo
No branches or pull requests
I tried using
fastapi-pagination
on a FastAPI + Databases project where I ran databases version 0.9.0 with SQLAlchemy > 2.0.This line fails: https://github.com/uriyyo/fastapi-pagination/blob/main/fastapi_pagination/ext/databases.py#L30
select([func.count()])
needs to becomeselect(func.count())
(i.e. remove brackets) for SQLAlchemy 2.0.I'm not sure how you want to handle compatibility with different versions of SQLAlchemy, otherwise I would have created a PR.
The text was updated successfully, but these errors were encountered: