-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn when logging buffer is full #103
Labels
enhancement
New feature or request
Comments
stephane-caron
changed the title
Log when circular buffer is full
Warn when logging buffer is full
May 29, 2024
stephane-caron
added a commit
that referenced
this issue
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As discussed with @ubgk today, currently we don't check that logging succeeds at every spine cycle:
vulp/vulp/spine/Spine.cpp
Line 72 in af23b12
The output from
mpacklog::Logger::put
is a success boolean. When it fails we should warn users that some log entries are being lost. (Perhaps suggest follow-up actions such as (1) increasing the size of the circular buffer or (2) reducing the size of logged dictionaries.)The text was updated successfully, but these errors were encountered: