Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for improved clarity of supported torch versions #444

Open
oadams opened this issue May 10, 2024 · 1 comment
Open

Suggestion for improved clarity of supported torch versions #444

oadams opened this issue May 10, 2024 · 1 comment
Labels
currently fixing Am fixing now!

Comments

@oadams
Copy link

oadams commented May 10, 2024

In the pip installation section, options are given for different pytorch versions. These versions cap at 2.2.1. Unsloth appears to work for me on pytorch 2.3.0 and in fact the dependency xformers wants pytorch 2.3.0 and issues warnings when using 2.2.1, with less availability when I call python -m xformers.info. Perhaps the docs could reflect support for versions higher than 2.2.1, and maybe even encourage 2.3.0 if that is appropriate?

Thanks for all your work on this amazing library.

@danielhanchen
Copy link
Contributor

Oh we ask people now to install !pip install --no-deps "xformers<0.0.26" trl peft accelerate bitsandbytes

But I agree the docs need to be clearer.

@danielhanchen danielhanchen added the currently fixing Am fixing now! label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
currently fixing Am fixing now!
Projects
None yet
Development

No branches or pull requests

2 participants