New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jinja2 Fails at 50% #433
Labels
currently fixing
Am fixing now!
Comments
Oh nice catch!! Did not know about Jinja2 - thanks for that - will add it in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
So while I was trying to train a model, at exactly the halfway point, I encountered and error because Jinja2 was not installed. While this is an easily resolvable error, the fact that it happened to begin with is the real issue. I think under ideal circumstances that the library should be installed during the unsloth installation procedure. And dependencies preferably checked and validated during runtime at program startup.
Prior to this run I pulled an update from github as per the instructions at https://github.com/unslothai/unsloth/wiki which do indeed mention "without dependency updates" which I wrongly assumed to mean "You dont have to ever update dependencies under any circumstance when updating unsloth" This sentiment was compounded by the lack of a section giving instructions for updating dependencies. It is my recommendation to add information to the wiki detailing how to update dependencies, as well as information about how to determine if dependency updates are needed.
While I do understand that I can read every line of the source code for unsloth and all of its dependencies in order to guide myself in the proper direction when using unsloth, I very much feel that over all desire of unsloth is to abstract the details away from the user and to provide a useful, easy to use tool suitable for end use. Therefore providing the proposed changes seems to be a good step toward achieving that goal and is the reason I am reporting this as an issue.
The text was updated successfully, but these errors were encountered: