Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look at explicit port for cross-origin detection #596

Open
brunosedler opened this issue Mar 14, 2024 · 1 comment
Open

Look at explicit port for cross-origin detection #596

brunosedler opened this issue Mar 14, 2024 · 1 comment

Comments

@brunosedler
Copy link

Bug description

By default, unpoly does not follow links if the href does not contain the current application host. However, hrefs that contain a port do not match the application-host-regex and are therefore not followed by unpoly by default.
The crossOrigin function needs to be adapted accordingly.

Expected behavior

Links to the same domain, that also include a port in the href should also be followed by unpoly.

@triskweline triskweline changed the title URLs containing the application host plus a port should not be interpreted as cross-origin Look at explicit port for cross-origin detection Mar 18, 2024
@triskweline
Copy link
Contributor

Links to the same domain, that also include a port in the href should also be followed by unpoly.

The port must match that of the document. A different port would constitute a different origin and cannot be followed by Unpoly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants