fix: failing test test_jax_min #28738
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ishticode
reviewed
Apr 26, 2024
There was a problem hiding this comment.
Hi. Thanks for the PR @tanmaymunjal
looks good. I guess it doesn't support complex128 either. usually "complex" should include both but there is some underlying bug with the decorator yet to be fixed. Maybe add complex128 and will get this merged. THanks for looking into this. :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The test test_jax_min failing seems to be an issue that when two floats are very close, paddle's real function will just approximate them as equal while jax will not.
Related Issue
Closes #28737
Checklist
Socials
https://twitter.com/free_thinker_9