fix: failing tests for torch.linalg.norm #28691
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy-leaves
added
the
PyTorch Frontend
Ishticode
requested changes
Apr 1, 2024
There was a problem hiding this comment.
Hi @Medo072
Thank you very much for the PR.
Few requests. Could you please exclude your changes to .devcontainer/devcontainer.josn.
As for the tests, it seems like the test this pr should fix is still failing in the CI as you can see in the logs under combined test results:
You should also be able to see this error locally.
Could you please fix these and request a review when done. Thank you very much :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #28690
Closes #28551
Checklist