Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage for built-in function options #752

Open
catamorphism opened this issue Mar 25, 2024 · 3 comments
Open

Improve test coverage for built-in function options #752

catamorphism opened this issue Mar 25, 2024 · 3 comments
Labels
LDML46 Items that must be first for post-tech preview (LDML46) test-suite

Comments

@catamorphism
Copy link
Collaborator

https://github.com/unicode-org/message-format-wg/blob/main/spec/registry.md lists many options for the built-in :number and :datetime functions. Eventually, spec tests should be added that at least cover each options, as well as some notable combinations of options (e.g. incompatible combinations of options). At this moment, only the minimumFractionDigits option for :number has tests, and most of the field options for :datetime don't have tests.

@catamorphism
Copy link
Collaborator Author

I'm not sure whether this belongs in LDML45 or LDML46. It's unlikely to be finished for 45, but adding more tests in 45 wouldn't break anything as long as they're consistent with the existing spec.

@aphillips
Copy link
Member

If we can do more tests for 45, great, but I'm fairly sure we won't get complete coverage in the days remaining. We should strive for that early in the Tech Preview phase. Once we have closed the book on 45, we'll probably do cadence releases during tech preview for things like this. So I'm going to tag this 46 but if you have tests, make a PR for 45.

@aphillips aphillips added the LDML46 Items that must be first for post-tech preview (LDML46) label Mar 26, 2024
@catamorphism
Copy link
Collaborator Author

I don't have tests yet, JFYI. I figured this would probably be a 46 thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LDML46 Items that must be first for post-tech preview (LDML46) test-suite
Projects
None yet
Development

No branches or pull requests

2 participants