This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
chore: Access field ref instead of current value #347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/rocketseat/unform/AKiBzzrLE4chJxmAnHifL8CdT971 |
diego3g
force-pushed
the
feat/use-refs-instead-of-values
branch
from
632aed0
to
451c385
Compare
diego3g
force-pushed
the
feat/use-refs-instead-of-values
branch
from
451c385
to
dfb0d23
Compare
Currently we used to pass the ref.current value to registerField function, but with that Unform was referencing the current value and no the reference itself and sometimes we were losing track of the reference to get the field value. Fixes #339.
diego3g
force-pushed
the
feat/use-refs-instead-of-values
branch
from
dfb0d23
to
633b272
Compare
jpedroschmitz
approved these changes
Mar 31, 2021
|
@diego3g vai rolar esse update? |
GustavoSchuler
approved these changes
Mar 31, 2022
|
@GustavoSchuler Vai sim, to subindo uma nova branch com uma v3 onde vai ter esse update e mais alguns outros. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed
Currently we used to pass the
ref.currentvalue toregisterFieldfunction, but with that Unform was referencing the current value and no the reference itself and sometimes we were losing track of the reference to get the field value.Fixes #339.