-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a question about fkl code? #52
Labels
Comments
Hi! Please see #26 (comment) I believe this is a mistake I made. If you fix it please consider submitting a PR request. Note that this code is used for visualization only, so it does not affect training/validation. Cheers, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi Julieta,
Thank you for releasing your code.
I am a little bit confused about these code in fkl.
human-motion-prediction/src/forward_kinematics.py
Lines 41 to 43 in c9a2774
human-motion-prediction/src/forward_kinematics.py
Line 48 in c9a2774
In angles variable, there should only be expmap of rotation matrix for each joint except for the first three elements. Why these code use some of the elements as the positions of the joints?
Thank you
Wei
The text was updated successfully, but these errors were encountered: