Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

软件架构单一职责优化建议 #145

Open
jerry765 opened this issue Dec 18, 2023 · 1 comment
Open

软件架构单一职责优化建议 #145

jerry765 opened this issue Dec 18, 2023 · 1 comment

Comments

@jerry765
Copy link

在项目架构层面，我发现存在一些模块违反了单一职责原则，这可能导致模块的复杂性增加，难以维护和扩展。以下是一些潜在的优化点：

  • /store/modules/user.ts文件处理用户登录、获取用户信息、角色设置等多个职责。建议将用户认证（如登录）和用户信息管理（如获取用户信息、角色设置）分离成两个独立的模块。
  • /hooks/useFetchSelect.ts自定义钩子包含了两个相关度不高的逻辑。建议将这些钩子拆分为更细粒度的钩子，每个钩子专注于单一功能。

我计划基于这些观点对项目进行针对性的优化，以提高代码的可读性和可维护性。如有不妥之处，还请不吝赐教。
@jerry765 jerry765 mentioned this issue Dec 19, 2023
Open
@pany-ang
Copy link
Member

我最近有事耽搁，后面我会仔细查看你的所有 PR，非常感谢你的建议！

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pany-ang @jerry765