You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was tempted to post this as a bug, but I can understand the thinking behind the following getters in this Interface, but imho I feel that the following are one and the same.
IEnumerable<TagModel?> GetAllTags(string? group = null, string? culture = null);
IEnumerable<TagModel?> GetAllContentTags(string? group = null, string? culture = null);
Can I suggest, GetAllTags is either modified to do exactly what it says on the tin and gets ALL tags. i.e. includes orphaned tags that do not relate to ANY content. Alternatively, to save a breaking change a new one that either just gets orphaned content or one that truly gets ALL.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I was tempted to post this as a bug, but I can understand the thinking behind the following getters in this Interface, but imho I feel that the following are one and the same.
IEnumerable<TagModel?> GetAllTags(string? group = null, string? culture = null);
IEnumerable<TagModel?> GetAllContentTags(string? group = null, string? culture = null);
Can I suggest, GetAllTags is either modified to do exactly what it says on the tin and gets ALL tags. i.e. includes orphaned tags that do not relate to ANY content. Alternatively, to save a breaking change a new one that either just gets orphaned content or one that truly gets ALL.
Thoughts?
Beta Was this translation helpful? Give feedback.
All reactions