Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight search mode in leap like folke/tokyonight #68

Closed
guoliang opened this issue Jan 26, 2024 · 3 comments · Fixed by #79
Closed

Highlight search mode in leap like folke/tokyonight #68

guoliang opened this issue Jan 26, 2024 · 3 comments · Fixed by #79

Comments

@guoliang
Copy link

In folke's tokyo night theme https://github.com/folke/tokyonight.nvim
when running leap https://github.com/ggandor/leap.nvim it looks as following
image

while with bluloco it looks as following
image

@uloco
Copy link
Owner

uloco commented Jan 26, 2024

Why do you prefer the first one? I think in the current version it's easier to keep the syntax colors so you understand the code where you want to jump better. Altough I dont really like the highlight of the labels...

@uloco
Copy link
Owner

uloco commented Jan 27, 2024

I'll add a bluloco style label

@guoliang
Copy link
Author

I guess it’s a matter of taste. I thought it was quite clear, for instance, if I accidentally go into leap mode. But maybe the downside would be some difficulty in finding where to jump to, for when I actually want to use leap.

@uloco uloco linked a pull request Jun 5, 2024 that will close this issue
@uloco uloco closed this as completed in #79 Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants