From f71e192120275c0d8695c68737a1d70c91de9f96 Mon Sep 17 00:00:00 2001
From: amaa-99 <->
Date: Sat, 29 Jul 2023 23:35:32 +0200
Subject: [PATCH] * [Issue #1] Application crashes (immediately) after choosing
 ' View log' from the menu. Addressed a couple of lint warnings.

---
 .../ukanth/ufirewall/log/LogRecyclerViewAdapter.java | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/app/src/main/java/dev/ukanth/ufirewall/log/LogRecyclerViewAdapter.java b/app/src/main/java/dev/ukanth/ufirewall/log/LogRecyclerViewAdapter.java
index 5bcd8471..045bea98 100644
--- a/app/src/main/java/dev/ukanth/ufirewall/log/LogRecyclerViewAdapter.java
+++ b/app/src/main/java/dev/ukanth/ufirewall/log/LogRecyclerViewAdapter.java
@@ -3,7 +3,6 @@
 import static dev.ukanth.ufirewall.Api.TAG;
 
 import android.content.Context;
-import android.content.pm.PackageInfo;
 import android.content.pm.PackageManager;
 import android.graphics.drawable.Drawable;
 import android.view.LayoutInflater;
@@ -12,6 +11,7 @@
 import android.widget.ImageView;
 import android.widget.TextView;
 
+import androidx.annotation.NonNull;
 import androidx.recyclerview.widget.RecyclerView;
 
 import java.text.DateFormat;
@@ -29,10 +29,7 @@ public class LogRecyclerViewAdapter extends RecyclerView.Adapter<LogRecyclerView
 
     private final List<LogData> logData;
     private final Context context;
-    private LogData data;
-    private PackageInfo info;
     private final RecyclerItemClickListener recyclerItemClickListener;
-    private View mView;
 
     public LogRecyclerViewAdapter(final Context context, RecyclerItemClickListener recyclerItemClickListener) {
         this.context = context;
@@ -45,9 +42,10 @@ public void updateData(List<LogData> logDataList) {
         logData.addAll(logDataList);
     }
 
+    @NonNull
     @Override
     public ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
-        mView = LayoutInflater.from(parent.getContext()).inflate(R.layout.log_recycle_item, parent, false);
+        View mView = LayoutInflater.from(parent.getContext()).inflate(R.layout.log_recycle_item, parent, false);
         return new ViewHolder(mView);
     }
 
@@ -97,9 +95,9 @@ private Bitmap getAppIcon26(PackageManager mPackageManager, ApplicationInfo appl
 
     @Override
     public void onBindViewHolder(ViewHolder holder, int position) {
-        data = logData.get(position);
+        LogData data = logData.get(position);
         PackageManager manager = context.getPackageManager();
-        holder.bind(logData.get(position),recyclerItemClickListener);
+        holder.bind(logData.get(position), recyclerItemClickListener);
         try {
             Drawable applicationIcon = Api.getApplicationIcon(context, data.getUid());
             holder.icon.setBackground(applicationIcon);