From e2871dd995b0d64278a13afb4214309eb69234ec Mon Sep 17 00:00:00 2001 From: amaa-99 <-> Date: Fri, 22 Sep 2023 12:04:24 +0200 Subject: [PATCH] * [Issue #18] The date/time formatting is not consistent across all views. Removed commented out code and unused methods. --- .../ufirewall/log/LogDetailRecyclerViewAdapter.java | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/app/src/main/java/dev/ukanth/ufirewall/log/LogDetailRecyclerViewAdapter.java b/app/src/main/java/dev/ukanth/ufirewall/log/LogDetailRecyclerViewAdapter.java index dabd6d61..769fdbee 100644 --- a/app/src/main/java/dev/ukanth/ufirewall/log/LogDetailRecyclerViewAdapter.java +++ b/app/src/main/java/dev/ukanth/ufirewall/log/LogDetailRecyclerViewAdapter.java @@ -7,6 +7,7 @@ import android.widget.ImageView; import android.widget.TextView; +import androidx.annotation.NonNull; import androidx.recyclerview.widget.RecyclerView; import java.util.ArrayList; @@ -20,13 +21,11 @@ */ public class LogDetailRecyclerViewAdapter extends RecyclerView.Adapter { - private final List logData; private final Context context; private LogData data; private final RecyclerItemClickListener recyclerItemClickListener; - public LogDetailRecyclerViewAdapter(final Context context, RecyclerItemClickListener recyclerItemClickListener) { this.context = context; logData = new ArrayList<>(); @@ -39,6 +38,7 @@ public void updateData(List logDataList) { } @Override + @NonNull public ViewHolder onCreateViewHolder(ViewGroup parent, int viewType) { View mView = LayoutInflater.from(parent.getContext()).inflate(R.layout.logdetail_recycle_item, parent, false); return new ViewHolder(mView); @@ -83,9 +83,7 @@ public int getItemCount() { public static class ViewHolder extends RecyclerView.ViewHolder { final ImageView icon; - //final TextView appName; final TextView deniedTime; - //final TextView dataInterface; final TextView dataDest; final TextView dataSrc; final TextView dataProto; @@ -94,9 +92,7 @@ public static class ViewHolder extends RecyclerView.ViewHolder { public ViewHolder(View itemView) { super(itemView); icon = itemView.findViewById(R.id.data_icon); - //appName = (TextView)itemView.findViewById(R.id.app_name); deniedTime = itemView.findViewById(R.id.denied_time); - //dataInterface = (TextView)itemView.findViewById(R.id.data_interface); dataDest = itemView.findViewById(R.id.data_dest); dataSrc = itemView.findViewById(R.id.data_src); dataProto = itemView.findViewById(R.id.data_proto); @@ -112,9 +108,4 @@ public void onClick(View v) { }); } } - - public List getLogData() { - return logData; - } - }