-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
set/parse race conditions #53
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It would be better if the IP and UA could be passed directly to the
parse()
method rather than having to useset()
before.The parser should be stateless to avoid problems in race conditions. For example it could happen that two requests to our service which accesses the global Udger instance from inside an
async
function happen at the same time, leading to aset()
->set()
->parse()
->parse()
sequence where the second request overwrites the IP and UA of the first request before the first request gets to theparse()
method callThe text was updated successfully, but these errors were encountered: