Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb Links Not Working #176

Closed
thehaseebahmed opened this issue Sep 27, 2023 · 4 comments
Closed

Breadcrumb Links Not Working #176

thehaseebahmed opened this issue Sep 27, 2023 · 4 comments
Labels
enhancement New feature or request help wanted Extra attention is needed no-issue-activity wontfix This will not be worked on

Comments

@thehaseebahmed
Copy link

馃悶 Bug report

Description

Breadcrumbs are showing up but the URL is not clickable and in one of my local projects it is clickable but there is no href for the a tag. I tried looking at the code but couldn't find what could be the reason. Please take a look at the attached example and let me know if I'm doing something wrong in the setup.

馃敩 Minimal Reproduction

StackBlitz code here.

@thehaseebahmed thehaseebahmed added the bug Something isn't working label Sep 27, 2023
@github-actions
Copy link

Hello 馃憢 @thehaseebahmed
Thank you for raising an issue. We will investigate into the issue and get back to you as soon as possible. Please make sure you have given us as much context as possible.
Feel free to raise a PR if you can fix the issue. Check the local development guide

@udayvunnam
Copy link
Owner

@thehaseebahmed

The issue is in route definition where everything is defined flat

const routes: Routes = [
  { path: '', component: HomeComponent },
  { path: 'home', component: HomeComponent },
  { path: 'contact', component: ContactComponent },
  { path: 'products', component: ProductsComponent },
  { path: 'product/:id', component: ProductComponent },
  { path: 'users', component: UsersComponent },
  { path: 'user/:id/:name', component: UserComponent },
];

Please try as shown in https://udayvunnam.github.io/xng-breadcrumb/#/where-to-define-breadcrumbs?id=with-component-and-its-children, add children.

We could support multilevel path but that would need some enhancement

@udayvunnam udayvunnam added enhancement New feature or request help wanted Extra attention is needed and removed bug Something isn't working labels Nov 17, 2023
Copy link

stale bot commented Mar 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Mar 17, 2024
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed no-issue-activity wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants